Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make asynchronous streaming threads daemons #268

Closed
wants to merge 1 commit into from
Closed

Make asynchronous streaming threads daemons #268

wants to merge 1 commit into from

Conversation

Aaron1011
Copy link
Contributor

I made streaming threads daemons when async is set to True.
See issue #70

@joshthecoder
Copy link
Member

I don't think this can be accepted without affecting existing code in a bad way. I would be more open to just exposing the thread object so developers can do this on their own if needed.

@Aaron1011 Aaron1011 mentioned this pull request Aug 20, 2013
Closed
@mmontagna mmontagna mentioned this pull request Nov 7, 2018
Merged
@Harmon758 Harmon758 added Improvement This is regarding an improvement to an existing feature Stale This is inactive, outdated, too old, or no longer applicable labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Improvement This is regarding an improvement to an existing feature Stale This is inactive, outdated, too old, or no longer applicable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Aaron1011 @joshthecoder @Harmon758